Fix spacing and layout of registered TopBar items #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <[email protected]>
Nokel81
requested review from
jakolehm and
Iku-turso
and removed request for
a team
Nokel81
commented
Mar 10, 2022
| onClick={goForward} | ||
| disabled={!nextEnabled.get()} | ||
| /> | ||
| </div> | ||
| <div className={styles.controls}> | ||
| <div className={styles.items}> | ||
| {renderRegisteredItems(items.get())} |
There was a problem hiding this comment.
Note, it should now be relatively easy to add the ability to add items to either side via the extension API. That, however, is left for future work.
|
Thank you for the fix! |
Merged
jim-docker
reviewed
Mar 14, 2022
|
Would you mind providing the extension registration code? |
ah, never mind, just realized it is coming from my extension, sorry |
jim-docker
approved these changes
Mar 14, 2022
|
Yeah we don't clip it at all. Can you merge this PR once the release has been made? |
do we need to wait? |
|
No, I realized that that release is from a different branch. |
jim-docker
pushed a commit
that referenced
this pull request
Mar 17, 2022
Merged
jim-docker
added a commit
that referenced
this pull request
Mar 17, 2022
* Fix spacing and layout of registered TopBar items (#4991) * Fix: overlapped pod logs (#5029) * release v5.4.3 Signed-off-by: Jim Ehrismann <[email protected]> Co-authored-by: Sebastian Malton <[email protected]> Co-authored-by: Alex Andreev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton [email protected]
Before:
After (with window buttons):
After (without window buttons):
